Introduce RenegotiatedFundingLocked monitor update variant #3894
Conversation
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
|
🔔 1st Reminder Hey @jkczyz! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @jkczyz! This PR has been waiting for your review. |
|
🔔 3rd Reminder Hey @jkczyz! This PR has been waiting for your review. |
|
🔔 4th Reminder Hey @jkczyz! This PR has been waiting for your review. |
|
🔔 5th Reminder Hey @jkczyz! This PR has been waiting for your review. |
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
wpaulino
force-pushed
the
renegotiated-funding-locked-monitor-update
branch
2 times, most recently
from
00e8bb3 to
c1ead6a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3894 +/- ##
==========================================
- Coverage 89.65% 88.97% -0.69%
==========================================
Files 164 166 +2
Lines 134658 119725 -14933
Branches 134658 119725 -14933
==========================================
- Hits 120734 106520 -14214
+ Misses 11246 10781 -465
+ Partials 2678 2424 -254
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is a new `ChannelMonitorUpdateStep` variant intended to be used whenever a new funding transaction that was negotiated and applied via the `RenegotiatedFunding` update reaches its intended confirmation depth and both sides of the channel exchange `channel_ready`/`splice_locked`. This commit primarily focuses on its use for splices, but future work will expand where needed to support RBFs for a dual funded channel. This monitor update ensures that the monitor can safely drop all prior commitment data since it is now considered invalid/unnecessary. Once the update is applied, only state for the new funding transaction is tracked going forward, until the monitor receives another `RenegotiatedFunding` update.
wpaulino
force-pushed
the
renegotiated-funding-locked-monitor-update
branch
from
c1ead6a to
a6d4b1e
Compare
| self.funding.prev_holder_commitment_tx.clone(), | ||
| ); | ||
|
|
||
| for funding in self.pending_funding.drain(..) { |
There was a problem hiding this comment.
Might be worth noting that the swap above allows us to clean up both the previous funding and any pending RBFs.
This is a new
ChannelMonitorUpdateStepvariant intended to be used whenever a new funding transaction that was negotiated and applied via theRenegotiatedFundingupdate reaches its intended confirmation depth and both sides of the channel exchangechannel_ready/splice_locked. This commit primarily focuses on its use for splices, but future work will expand where needed to support RBFs for a dual funded channel.This monitor update ensures that the monitor can safely drop all prior commitment data since it is now considered invalid/unnecessary. Once the update is applied, only state for the new funding transaction is tracked going forward, until the monitor receives another
RenegotiatedFundingupdate.